Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR:
NDialog
class to serve as an in-between class forQDialog
. Currently, all it adds is an overload ofkeyPressEvent
to capture Escape key presses and redirect them toclose()
. The default behaviour of Qt hides the dialog without going through close, thus bypassing thecloseEvent
logic.QDialog.deleteLater()
calls with a newNDialog.softDelete()
method that simply setsself.setParent(None)
. This seems to play better together with the Python garbage collector. The Qt object does not seem to be deleted before it is released by the Python side.deleteLater()
calls onQMessageBox
objects. They seem to be deleted on close already.Related Issue(s):
Reviewer's Checklist: